Open tsalo opened 3 years ago
I think I've got a mostly functional prototype up in this notebook.
I was playing with the previous version when "there was something iffy with the way I did the filtering". It seems you got it sorted. Regarding your questions about 2*np.pi, it seems to normalize radians. Anyway, it is an scaling factor that does not influence the rest of the commands (unless the ones in the notebook)
Thanks! That's really helpful. I was just working on moving the contents (without changes) to a new branch, so I'm going to open a draft PR if you want to add any comments directly.
Harrison et al. (2020) proposes a new filtering approach when calculating respiration-based metrics (especially respiratory volume per unit time [RVT]) that is supposedly better able to capture atypical breathing (e.g., deep breaths). While it's just a preprint, I think it's worth looking into this method to see if it's worth supporting in
phys2denoise
.Here are the details of the algorithm, taken from the manuscript: