Fix window calculation in env

physiopy / phys2denoise

A toolbox and collection of scripts to prepare physiology data for fMRI denoise

https://phys2denoise.readthedocs.io/

Apache License 2.0

9 stars 19 forks source link

Fix window calculation in env #33

Closed rzlim08 closed 3 years ago

rzlim08 commented 3 years ago

https://github.com/physiopy/phys2denoise/blob/cfced3b47e7e7e4254e775cdfbc448e4c7cb15b0/phys2denoise/metrics/chest_belt.py#L95

@tsalo just adding some tests right now, but I think the window calculation for ENV needs to be looked at here. I'm not sure, but I don't think dividing by the out_samplerate is right. Also, I think it needs to be cast to an int.

tsalo commented 3 years ago

Agreed. Thanks!

rzlim08 commented 3 years ago

actually I just saw that you've fixed it in your latest PR, sorry I missed that!