Fix lag application for negative lags

[tsalo]

Closes #35.

This PR corrects the calculation of negative lags.

Proposed Changes

• Remove unused lags parameter in rv function.
• Use the absolute lag when applying negative lags.
• Replace uses of numpy.int (deprecated) with int.

Change Type

• [ ] bugfix (+0.0.1)
• [x] minor (+0.1.0)
• [ ] major (+1.0.0)
• [ ] refactoring (no version update)
• [ ] test (no version update)
• [ ] infrastructure (no version update)
• [x] documentation (no version update)
• [ ] other

Checklist before review

• [x] I added everything I wanted to add to this PR.
• [x] [Code or tests only] I wrote/updated the necessary docstrings.
• [ ] [Code or tests only] I ran and passed tests locally.
• [ ] [Documentation only] I built the docs locally.
• [x] My contribution is harmonious with the rest of the code: I'm not introducing repetitions.
• [x] My code respects the adopted style, especially linting conventions.
• [x] The title of this PR is explanatory on its own, enough to be understood as part of a changelog.
• [ ] I added or indicated the right labels.
• [ ] I added information regarding the timeline of completion for this PR.
• [x] Please, comment on my PR while it's a draft and give me feedback on the development!

[smoia]

Actually, @tsalo, it's difficult for me to figure out which changes you wanted to stay - can you resolve the conflicts with master, please?

[tsalo]

Sorry for the delay @smoia. I'll give that a try now.

[tsalo]

I ended up having to change a few things. Lags were removed from rv at some point, but the parameter was still there, so I removed the parameter.

Also, lags in apply_lags wasn't applying lags correctly, AFAICT. I think I've fixed that.

[codecov[bot]]

Codecov Report

Merging #36 (f7c85b1) into master (24515ca) will not change coverage. The diff coverage is 33.33%.

Additional details and impacted files

[](https://codecov.io/gh/physiopy/phys2denoise/pull/36?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=physiopy) ```diff @@ Coverage Diff @@ ## master #36 +/- ## ======================================= Coverage 47.04% 47.04% ======================================= Files 7 7 Lines 321 321 ======================================= Hits 151 151 Misses 170 170 ``` | [Impacted Files](https://codecov.io/gh/physiopy/phys2denoise/pull/36?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=physiopy) | Coverage Δ | | |---|---|---| | [phys2denoise/metrics/cardiac.py](https://codecov.io/gh/physiopy/phys2denoise/pull/36?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=physiopy#diff-cGh5czJkZW5vaXNlL21ldHJpY3MvY2FyZGlhYy5weQ==) | `94.73% <ø> (ø)` | | | [phys2denoise/metrics/utils.py](https://codecov.io/gh/physiopy/phys2denoise/pull/36?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=physiopy#diff-cGh5czJkZW5vaXNlL21ldHJpY3MvdXRpbHMucHk=) | `69.56% <0.00%> (ø)` | | | [phys2denoise/metrics/chest\_belt.py](https://codecov.io/gh/physiopy/phys2denoise/pull/36?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=physiopy#diff-cGh5czJkZW5vaXNlL21ldHJpY3MvY2hlc3RfYmVsdC5weQ==) | `85.54% <100.00%> (ø)` | |