physiopy / physioqc

Toolbox for physiological data (Automagic) Quality Control
Apache License 2.0
2 stars 8 forks source link

Problem in physioqc.interfaces.interfaces.run metrics() #10

Open celprov opened 1 year ago

celprov commented 1 year ago

Stuff that needs to be addressed after the code developed for OHBM23.

If the function m is peak_amplitude or peak_distance, you should first run peak_detection and then pass the output of peak_detection to the latter.

SRSteinkamp commented 1 year ago

Alternatively, just run peak_detection at the beginning, while that means that peaks and troughs will also be plotted on the raw-data plot, which I think is fine (I could also implement something to suppress it), peak_amplitude / peak_distance will work without further adjustments.