physiopy / physutils

Common tools for the physiopy suite
Apache License 2.0
0 stars 4 forks source link

Integrate the MRIConfig and Physio classes #5

Open maestroque opened 3 months ago

maestroque commented 3 months ago

Goal

The main scope of the MRIConfig class is to contain all the relevant information about the MRI scan, that are useful in the following steps of the data processing workflow. These are currently stemming from phys2denoise functions, namely slice_timings, n_scans and tr and are used in metrics computations. Integrating a structure containing those into the Physio object would greatly facilitate the relevant workflow.

Implementation

The acquisition of those parameters could be:

Especially in case this is done through the load_from_bids function, the trigger channel would be automatically used as a source of acquisition, unless specified against.

Then, the load_from_bids function should output an object containing the array of Physio objects, and an MRIConfig class. This could be the aforementioned multimodal Physio class.

maestroque commented 3 months ago

@smoia @m-miedema @me-pic I think I should prioritize the p2d workflow and then if time allows implement this. Wdyt?

me-pic commented 3 months ago

Sounds reasonable to me !

m-miedema commented 3 months ago

Yes, definitely!

m-miedema commented 3 months ago

I want to link my comment here since it's relevant to the goals of this issue.