search

phytec / doc-bsp-yocto

Yocto BSP Documentation
https://phytec.github.io/doc-bsp-yocto/
1 stars 1 forks source link

BSPIMX8M-1826 add documentation for PD23.1.0 #133

Closed BHahn42618 closed 9 months ago

BHahn42618 commented 10 months ago

add PD23.1.0 BSP Manual

tremmet commented 10 months ago

@BHahn42618 please remove the doc-id part for now. The L-number is only used for internal documentation archiving. And not required for now.

tremmet commented 9 months ago

@BHahn42618 can the be reviewed now?

jonas-rem commented 9 months ago

@BHahn42618 sorry just saw your do-not-merge comment now (after merging). Is this a problem for #137?

BHahn42618 commented 9 months ago

@BHahn42618 sorry just saw your do-not-merge comment now (after merging). Is this a problem for #137?

No this should not neccessarily be a problem. The plan was to merge #137 first and then this one, so we can make a tag with this commit tagged, as the release version. At the moment the Yocto manual is not reworked yet, so the "Kirkstone" Manual I referenced in this commit does not exist yet. @tremmet Or what do you say? Should this be reverted?

jonas-rem commented 9 months ago

@BHahn42618 sorry just saw your do-not-merge comment now (after merging). Is this a problem for #137?

No this should not neccessarily be a problem. The plan was to merge #137 first and then this one, so we can make a tag with this commit tagged, as the release version. At the moment the Yocto manual is not reworked yet, so the "Kirkstone" Manual I referenced in this commit does not exist yet. @tremmet Or what do you say? Should this be reverted?

Ah ok. That should not be a problem, we can apply the tag anytime on any commit. There are no PRs necessary for tags. I don't think it's an issue if the tag is on a Yocto manual commit in the end.

tremmet commented 9 months ago

@BHahn42618 @jremmert-phytec-iot This is fine. As Jonas said. A tag can be also created based on the Yocto manual commit or whatever comes last.