cleaning the `Book_of_potions` directory

phyver / GameShell

a game to learn (or teach) how to use standard commands in a Unix shell

GNU General Public License v3.0

2.13k stars 135 forks source link

cleaning the `Book_of_potions` directory #64

Closed phyver closed 2 years ago

phyver commented 2 years ago

If the user creates spurious files in Book_of_potions, they are not removed when the mission is reset.

phyver commented 2 years ago

That should be fixed by fc1585f5

@oupala do you think changing the error messages (when some files have been created) or the order of the tests (location of player then the book instead of the other way around) would be better?

oupala commented 2 years ago

In fact, I don't see why both cases should be error.

If the user is adding some files to the book (like adding a new receipe), it should not be a problem.
If the user is diving into the "book of potions" directory, why should it be a problem?

As long as the mission goal is reached, the mission should be a success:

[mission 22] $ cd World/Mountain/Cave/Book_of_potions

oupala commented 2 years ago

Currently, the script does not detect if I'm inside the book of potion.

It is however detecting that I altered the book of potion. But nothing told me not to alter the book of potion. If it is really forbidden to alter the book of potion, the book of potion should be read-only.