pi-base / web

Code powering the π-Base
https://topology.pi-base.org
MIT License
5 stars 5 forks source link

Fix copy citation button #162

Closed StevenClontz closed 1 week ago

StevenClontz commented 2 months ago

In addition to the fix at #164, we have another issue. When visiting https://topology.pi-base.org/spaces one can edit the search parameters, and it appears to update the citation for that page. However, those updates aren't reflected in the copied text from the Markdown button. We should fix this.

StevenClontz commented 2 months ago

I believe https://github.com/pi-base/web/pull/157 has a hint on what we might need to do (use #key to force the component to rerender given new values for the text to be copied).

prabau commented 1 month ago

Has #164 done anything? It used to be that the Copy: Markdown link button on the Explore page would copy something that would display the current search. But that behavior became broken at some point. And that it still broken, even with #164. What we get is just:

[π-Base, Explore](https://topology.pi-base.org/spaces)

StevenClontz commented 1 month ago

I think it fixed the front page button, but there's still work to do on the explore page.

StevenClontz commented 1 week ago

Closed by #170