pi-engine / pi

Multi-tenant application development engine for cloud ready SaaS platform.
http://www.piengine.org
202 stars 115 forks source link

Boostrap 4 + jQuery 3 #1464

Open Marc-pi opened 7 years ago

Marc-pi commented 7 years ago

from https://github.com/pi-engine/guide/issues/842 and https://github.com/pi-engine/guide/issues/841

voltan commented 6 years ago

For update to boostrap 4 and fontawesome to version 5:

voltan commented 6 years ago

I think update to jquery 3 finished

Marc-pi commented 6 years ago

that's a huge work, i've added a task about other js libs if we want to be good (performance wise), i think we have to work on pure BS4, not using their compat script

voltan commented 6 years ago

Understand , than I use not compacted version for all libes

Marc-pi commented 6 years ago

https://getbootstrap.com/docs/4.1/migration/ i thought there were a code js snippet to run BS3 code on BS4 engine, maybe they remove.

btw, impact on Fontawesome also, maybe we have to update to FA5 too...

than I use not compacted version for all libes

of course please install minified version of all libs, but we need to check compatibility of our jquery plugins and other libs we use (Angular, CKEditor, etc.)

voltan commented 6 years ago

btw, impact on Fontawesome also, maybe we have to update to FA5 too...

Its my plan

of course please install minified version of all libs, but we need to check compatibility of our jquery plugins and other libs we use (Angular, CKEditor, etc.)

OK , sure

I will use this dco too https://getbootstrap.com/docs/4.1/migration/

Marc-pi commented 6 years ago

@voltan don't forget admin side !!!