pi-hole / FTL

The Pi-hole FTL engine
https://pi-hole.net
Other
1.34k stars 187 forks source link

Don't print double newlines after invalid domains #1854

Closed yubiuser closed 5 months ago

yubiuser commented 6 months ago

Don't print double newlines after invalid domains.

  [i] Target: https://v.firebog.net/hosts/Easyprivacy.txt
  [✓] Status: Retrieval successful
  [✓] Parsed 32268 exact domains and 0 ABP-style domains (blocking, ignored 5 non-domain entries)
      Sample of non-domain entries:
        - emam
        - smcom
        - smetriccom
        - smetrics.previcox.d
        - welcome..org

  [i] Target: https://v.firebog.net/hosts/Prigent-Ads.txt
  [✓] Status: Retrieval successful
  [✓] Parsed 3700 exact domains and 0 ABP-style domains (blocking, ignored 0 non-domain entries)

  [i] Target: https://raw.githubusercontent.com/FadeMind/hosts.extras/master/add.2o7Net/hosts
  [✓] Status: Retrieval successful
  [✓] Parsed 2030 exact domains and 0 ABP-style domains (blocking, ignored 0 non-domain entries)

  [i] Target: https://raw.githubusercontent.com/crazy-max/WindowsSpyBlocker/master/data/hosts/spy.txt
  [✓] Status: Retrieval successful
  [✓] Parsed 347 exact domains and 0 ABP-style domains (blocking, ignored 0 non-domain entries)

  [i] Target: file:///etc/pihole/test_list.txt
  [✓] Status: Retrieval successful
  [✓] Parsed 0 exact domains and 1 ABP-style domains (blocking, ignored 1 non-domain entries)
      Sample of non-domain entries:
        - com

  [✓] Building tree
  [i] Number of gravity domains: 354963 (352248 unique domains)

By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.