pi-hole / FTL

The Pi-hole FTL engine
https://pi-hole.net
Other
1.34k stars 187 forks source link

Improve config migration logging #1891

Closed DL6ER closed 4 months ago

DL6ER commented 4 months ago

What does this implement/fix?

No functional change This PR addresses a message which unnecessarily concerned a user in the related Discourse thread. We solve this by not logging this message unless debug.config = true is explicitly set. There is no issue at all when this message appears. It simply means the config wasn't old - as the old item wasn't there, it didn't need migration.

While I was at it, I expanded the comments around this code to make clear what the code does and why it may reach one or the other place.


Related issue or feature (if applicable): see link above

Pull request in docs with documentation (if applicable): N/A


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

Checklist:

pralor-bot commented 4 months ago

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pihole-v6-update-seems-to-break-my-install/68376/5