Allow upper case letters in domains/hosts - Githubissues

pi-hole / FTL

The Pi-hole FTL engine

https://pi-hole.net

Other

1.34k stars 187 forks source link

Allow upper case letters in domains/hosts #1910

Closed PromoFaux closed 3 months ago

PromoFaux commented 3 months ago

What does this PR aim to accomplish?:

Uncomment some previously commented out code that prevents domains from including upper case letters. See https://discourse.pi-hole.net/t/local-dns-settings-x-invalid-value/68985 for details

Before:

After:

By submitting this pull request, I confirm the following:

I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
I have commented my proposed changes within the code and I have tested my changes.
I am willing to help maintain this change if there are issues with it later.
It is compatible with the EUPL 1.2 license
I have squashed any insignificant commits. (git rebase)

[x] I have read the above and my PR is ready for review. Check this box to confirm

pralor-bot commented 3 months ago

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/local-dns-settings-x-invalid-value/68985/5