Fix pipe transmission from forked dnsmasq process validation changed configurations. This had no real consequences but could lead to missing characters in error messages describing how a new config is invalid (if a user added something invalid). However, as we are testing for this, the CI sometimes automatically retried the jobs most often resulting in a success, eventually.
Example for such an issue:
(mind the missing initial 'N' of Name does not...)
This PR ensures we properly flush the pipe (by sending 32 bytes of Domestos down the line) before using it so no dirt gets stuck on its way.
Note: Interestingly enough, this has never happened on any of the native builds (not even on the ARM builds on the new ARM64 self-hosted runners) but always only in the emulated buildx environments. Currently, this only affects riscv64.
Related issue or feature (if applicable): N/A
Pull request in docs with documentation (if applicable): N/A
By submitting this pull request, I confirm the following:
I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
I have commented my proposed changes within the code.
I am willing to help maintain this change if there are issues with it later.
What does this implement/fix?
Fix pipe transmission from forked dnsmasq process validation changed configurations. This had no real consequences but could lead to missing characters in error messages describing how a new config is invalid (if a user added something invalid). However, as we are testing for this, the CI sometimes automatically retried the jobs most often resulting in a success, eventually.
Example for such an issue:
(mind the missing initial 'N' of
Name does not...
)This PR ensures we properly flush the pipe (by sending 32 bytes of Domestos down the line) before using it so no dirt gets stuck on its way.
Note: Interestingly enough, this has never happened on any of the native builds (not even on the ARM builds on the new ARM64 self-hosted runners) but always only in the emulated
buildx
environments. Currently, this only affectsriscv64
.Related issue or feature (if applicable): N/A
Pull request in docs with documentation (if applicable): N/A
By submitting this pull request, I confirm the following:
git rebase
)Checklist:
developmental
branch.