pi-hole / FTL

The Pi-hole FTL engine
https://pi-hole.net
Other
1.34k stars 187 forks source link

Fix a crash resulting from a bad interaction between PRs #1928 and #1930 #1936

Closed DL6ER closed 2 months ago

DL6ER commented 2 months ago

What does this implement/fix?

Fix a crash resulting from a bad interaction between PRs #1928 and #1930. The fix is very simple: #1928 made it unnecessary to specify the number of following arguments. Unfortunately, current development-v6 misinterprets this causing a crash as reported in #1935

Related issue or feature (if applicable): fixes #1935

Pull request in docs with documentation (if applicable): N/A


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

Checklist:

pralor-bot commented 2 months ago

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/ftl-started-crashing/69712/2