pi-hole / FTL

The Pi-hole FTL engine
https://pi-hole.net
Other
1.34k stars 187 forks source link

Update DNS records after pruning DHCP leases #1965

Closed DL6ER closed 1 month ago

DL6ER commented 1 month ago

What does this implement/fix?

This PR adds a commit submitted to the dnsmasq-discuss mailing list. It has been verified by users to prevent use-after-free bugs possibly even resulting in a crash when names for meanwhile expired DHCP leases are queried via DNS PTR.

In case this patch is not accepted 1:1 for dnsmasq upstream, we can easily revert this PR later.


Related issue or feature (if applicable): N/A

Pull request in docs with documentation (if applicable): N/A


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

Checklist:

pralor-bot commented 1 month ago

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/host-name-of-client-xxx-contains-at-least-one-invalid-character-at-position-0/69132/84