pi-hole / FTL

The Pi-hole FTL engine
https://pi-hole.net
Other
1.34k stars 187 forks source link

Fix chown of aux. database files #1973

Closed DL6ER closed 1 month ago

DL6ER commented 1 month ago

What does this implement/fix?

Always try to chown auxiliary database files, not only when chown of the database files itself failed. I simplified and re-arranged the code to reduce the nesting depth by up to two levels, making such issues easier to detect visually.


Related issue or feature (if applicable): N/A

Pull request in docs with documentation (if applicable): N/A


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

Checklist:

pralor-bot commented 1 month ago

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/usage-of-dnsmasqs-user-option-does-not-chown-db-shm-and-db-wal-files-on-first-launch/70244/9

DL6ER commented 1 month ago

@rdwebdesign fixed via force-push - to not waste a full-blown commit for a one character change