pi-hole / FTL

The Pi-hole FTL engine
https://pi-hole.net
Other
1.34k stars 187 forks source link

Add option to ignore unknown DHCP clients #1980

Closed DL6ER closed 1 month ago

DL6ER commented 1 month ago

What does this implement/fix?

Add new dhcp.ignoreUnknownClients option which has been requested on Discourse. It works as follows:

Screenshot from 2024-05-30 19-04-33

This PR also features a second commit updating forgotten changes into test/pihole.toml and adds a CI test to prevent forgetting to update this file in the future.


Related issue or feature (if applicable): https://discourse.pi-hole.net/t/add-checkbox-to-block-dhcp-for-unknown-hosts/70485

Pull request in docs with documentation (if applicable): N/A


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

Checklist:

pralor-bot commented 1 month ago

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/add-checkbox-to-block-dhcp-for-unknown-hosts/70485/5

rdwebdesign commented 1 month ago

Should we add this option on the web interface, Settings > DHCP page?

Something like this?

Or this should be only in "All settings" page?

DL6ER commented 1 month ago

@rdwebdesign In the end, yes. But it'll be a separate PR and I haven't had the chance to do it myself, so far. Please go ahead :-)