Closed DL6ER closed 6 days ago
This pull request has conflicts, please resolve those before we can evaluate the pull request.
Conflicts have been resolved.
Has been confirmed working by original requestor on Discourse
Thank you, this was some very good review hint! The issue was that we skipped recomputing the checksum in read-only mode and, hence, FTL did not realize that the file actually changed once you went back from false -> true
. However, this bug was only triggered if you have changed other settings before this, effectively hiding it from my tests where I have set misc.readOnly = true
as the first thing during testing.
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:
https://discourse.pi-hole.net/t/support-writing-to-pihole-toml-directly/70522/11
What does this implement/fix?
Add new
misc.readOnly
config option to force the configuration to be read-only. It can only be modified through the config file but neither the API nor the CLI as long as read-only mode is enabled.Related issue or feature (if applicable): https://discourse.pi-hole.net/t/support-writing-to-pihole-toml-directly/70522/
Pull request in docs with documentation (if applicable): N/A
By submitting this pull request, I confirm the following:
git rebase
)Checklist:
developmental
branch.