pi-hole / FTL

The Pi-hole FTL engine
https://pi-hole.net
Other
1.34k stars 187 forks source link

Fix DNS-SD query analysis #2000

Closed DL6ER closed 1 week ago

DL6ER commented 1 week ago

What does this implement/fix?

Fix non-reverse PTR queries from being interpreted incorrectly. This issue existed for always but nobody has reported it before.


Related issue or feature (if applicable): see link to Discourse below

Pull request in docs with documentation (if applicable): N/A


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

Checklist:

pralor-bot commented 1 week ago

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/n-a-replies-in-dashboard-logs-show-that-query-was-answered-query-forwarding/70799/9

pralor-bot commented 1 week ago

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/n-a-replies-in-dashboard-logs-show-that-query-was-answered-query-forwarding/70799/9

PromoFaux commented 1 week ago

(also 2000 PRs... crikey!)