Do not take the not-filtered shortcut if one of the magic upstream={blocklist,cache} is selected via GET parameter. This is currently broken as detection of ongoing filtering is through variable binding to the SQL string. However, these two special upstreams work by using the IN operator which does not support binding to a prepared statement.
Pull request in docs with documentation (if applicable): N/A
By submitting this pull request, I confirm the following:
I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
I have commented my proposed changes within the code.
I am willing to help maintain this change if there are issues with it later.
What does this implement/fix?
Do not take the not-filtered shortcut if one of the magic
upstream={blocklist,cache}
is selected viaGET
parameter. This is currently broken as detection of ongoing filtering is through variable binding to the SQL string. However, these two special upstreams work by using the IN operator which does not support binding to a prepared statement.Related issue or feature (if applicable): https://discourse.pi-hole.net/t/incorrect-number-of-pages-in-query-log-if-only-blocked-domains-are-displayed/72622
Pull request in docs with documentation (if applicable): N/A
By submitting this pull request, I confirm the following:
git rebase
)Checklist:
developmental
branch.