pi-hole / FTL

The Pi-hole FTL engine
https://pi-hole.net
Other
1.39k stars 196 forks source link

Update --gen-x509 help text #2096

Closed DL6ER closed 4 weeks ago

DL6ER commented 4 weeks ago

What does this implement/fix?

Adds description for optional [domain]:

image


Related issue or feature (if applicable): https://discourse.pi-hole.net/t/fix-pihole-ftl-help-output-for-gen-x509-option-with-domain-parameter/73622

Pull request in docs with documentation (if applicable): N/A


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

Checklist:

pralor-bot commented 4 weeks ago

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/fix-pihole-ftl-help-output-for-gen-x509-option-with-domain-parameter/73622/2

rdwebdesign commented 4 weeks ago

One test (armv7) failed.

DL6ER commented 4 weeks ago

I kicked the test - it is entirely unrelated, apparently, something was off with the testing container (Failed to receive data from NTP server 127.0.0.1: Connection refused).