Go through network-table.c and ensure error handling is uniform, there were some cases in which an early returning caused by an error could have left prepared SQLite3 statements un-finalized. Whether this is the cause for occasional database locking we are seeing is unclear. However, the change
is specifically tailored to fix the cause of recently reported ERROR: add_netDB_network_address(-1, "192.168.0.168"): Failed to step (error 19): constraint failed messages.
Related issue or feature (if applicable): N/A
Pull request in docs with documentation (if applicable): N/A
By submitting this pull request, I confirm the following:
I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
I have commented my proposed changes within the code.
I am willing to help maintain this change if there are issues with it later.
DL6ER
commented
1 month ago
What does this implement/fix?
Go through network-table.c and ensure error handling is uniform, there were some cases in which an early returning caused by an error could have left prepared SQLite3 statements un-finalized. Whether this is the cause for occasional database locking we are seeing is unclear. However, the change
is specifically tailored to fix the cause of recently reported
ERROR: add_netDB_network_address(-1, "192.168.0.168"): Failed to step (error 19): constraint failedmessages.Related issue or feature (if applicable): N/A
Pull request in docs with documentation (if applicable): N/A
By submitting this pull request, I confirm the following:
git rebase)Checklist:
developmentalbranch.