search

pi-hole / FTL

The Pi-hole FTL engine
https://pi-hole.net
Other
1.39k stars 196 forks source link

Amend the help text of the TLS certificate #2098

Closed yubiuser closed 3 weeks ago

yubiuser commented 3 weeks ago

What does this PR aim to accomplish?:

Improve the help text of the webserver.tls.cert config.

Fixes https://discourse.pi-hole.net/t/v6-self-signed-certificate-issues/73640

By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.
pralor-bot commented 3 weeks ago

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/v6-self-signed-certificate-issues/73640/9

yubiuser commented 3 weeks ago

You'll also need to edit the test/pihole.toml file as the tests expect the file to be created correctly

I feared so.