search

pi-hole / FTL

The Pi-hole FTL engine
https://pi-hole.net
Other
1.39k stars 196 forks source link

dns.revServers insists on <domain> #2115

Closed DL6ER closed 2 weeks ago

DL6ER commented 2 weeks ago

Thank you, that works now. There is another validation issue with setting dns.revServers. Description says that format is <enabled>,<ip-address>[/<prefix-len>],<server>[#<port>][,<domain>], expecting `domain to be optional:

Image

However, values without the domain parameter are not accepted:

Image

Originally posted by @schuettecarsten in #2111

DL6ER commented 2 weeks ago

Thanks for the report. What you found is an inconsistency between web and FTL, if you look into /etc/pihole/pihole.toml, you'll see that <domain> is indeed not optional. However, I do agree that it being optional is useful and - as FTL can already handle this well - I made the validator accept entries without <domain> like what you are looking for.

DL6ER commented 2 weeks ago

Fix merged