pi-hole / FTL

The Pi-hole FTL engine
https://pi-hole.net
Other
1.39k stars 196 forks source link

Make <domain> optional in dns.revServer #2116

Closed DL6ER closed 1 week ago

DL6ER commented 1 week ago

What does this implement/fix?

Fixes https://github.com/pi-hole/FTL/issues/2115 by making <domain> optional for dns.revServer.

Before:

<enabled>,<ip-address>[/<prefix-len>],<server>[#<port>],<domain>

Now:

<enabled>,<ip-address>[/<prefix-len>],<server>[#<port>][,<domain>]

I labeled this Bugfix as it fixes an inconsistency between web (which is describing <domain> as being optional) and FTL (which insists on it before this PR).


Related issue or feature (if applicable): https://github.com/pi-hole/FTL/issues/2115

Pull request in docs with documentation (if applicable): N/A


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

Checklist: