When adding the three new shared memory objects for client, domain, and DNS cache lookup tables, we forgot to add the code ensuring they are remapped in all processes in case one process has to resize them to add further records. This resulted in TCP forks still trying to access the memory on the previous location where the object is no more present and will inevitable lead to memory corruption, possibly affecting other code regions (such as the very memory allocation intense sqlite3 library) or cause simple crashes due to trying to access non-allocated memory regions.
This PR fixes this and has been confirmed in #2112. Heavy TCP DNS activity was required to see this crash which is probably why it has neither been found during the reviewing process nor by the extensive CI testing suite.
The code in this PR has already been confirmed in #2112
Related issue or feature (if applicable): Fixes #2112
Pull request in docs with documentation (if applicable): N/A
By submitting this pull request, I confirm the following:
I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
I have commented my proposed changes within the code.
I am willing to help maintain this change if there are issues with it later.
What does this implement/fix?
When adding the three new shared memory objects for client, domain, and DNS cache lookup tables, we forgot to add the code ensuring they are remapped in all processes in case one process has to resize them to add further records. This resulted in TCP forks still trying to access the memory on the previous location where the object is no more present and will inevitable lead to memory corruption, possibly affecting other code regions (such as the very memory allocation intense
sqlite3library) or cause simple crashes due to trying to access non-allocated memory regions.This PR fixes this and has been confirmed in #2112. Heavy TCP DNS activity was required to see this crash which is probably why it has neither been found during the reviewing process nor by the extensive CI testing suite.
The code in this PR has already been confirmed in #2112
Related issue or feature (if applicable): Fixes #2112
Pull request in docs with documentation (if applicable): N/A
By submitting this pull request, I confirm the following:
git rebase)Checklist:
developmentalbranch.