pi-hole / FTL

The Pi-hole FTL engine
https://pi-hole.net
Other
1.36k stars 194 forks source link

List all clients from UI #220

Closed borpin closed 6 years ago

borpin commented 6 years ago

In raising this issue, I confirm the following (please check boxes, eg [X]) Failure to fill the template will close your issue:

How familiar are you with the codebase?:

1


[ISSUE] Expected Behaviour: It would be useful to be able to list all clients that are requesting DNS lookup through Pi-hole not just Top 10. It would show if a particular client was configured to use Pi-hole correctly as well as looking for rouge clients.

My C is not great but looking at the code I believe https://github.com/pi-hole/FTL/blob/master/request.c#L457 is where this lookup is handled.

If the function was made more general to include the 'count' as a parameter, it looks as if the function could be made more general (even offer a UI to display more items) or simply use 0 to display all clients in the logs.

This template was created based on the work of udemy-dl.

DL6ER commented 6 years ago

Issue moved to pi-hole/AdminLTE #679 via ZenHub