Missing mipsel architeture binaries

pi-hole / FTL

The Pi-hole FTL engine

https://pi-hole.net

Other

1.36k stars 194 forks source link

Missing mipsel architeture binaries #290

Closed Katana-Steel closed 6 years ago

Katana-Steel commented 6 years ago

In raising this issue, I confirm the following (please check boxes, eg [X]) Failure to fill the template will close your issue:

[X] I have read and understood the contributors guide.
[X] The issue I am reporting can be replicated
[X] The issue I am reporting isn't a duplicate

How familiar are you with the codebase?:

[BUG | ISSUE] Expected Behaviour: when updarting pihole on a mipsel device a binary is available

[BUG | ISSUE] Actual Behaviour: no mips binary is available,

[BUG | ISSUE] Steps to reproduce:

install/compile a pihole-FTL binary from a lower version (on mips)
use pihole -up to update

Log file output [if available]

Pending...

Device specifics

Hardware Type: Mips CI20 Creator OS: Debian 8 (jessie)

This template was created based on the work of udemy-dl.

AzureMarker commented 6 years ago

This is not a bug, FTL does not currently support MIPS. Have you tried compiling FTL from source to see if it would even work?

Katana-Steel commented 6 years ago

I have compiled v3.0 from source and it starts. I'm just not seeing any data on the pihole dashboard

AzureMarker commented 6 years ago

Have you tried compiling development?

AzureMarker commented 6 years ago

Also, it is unlikely that FTL will add support for MIPS because the upcoming API will not support it (a native dependency does not support it).

janisz commented 4 years ago

I've build and successfully use pi-hole on CI20 with cloudflared. In attachment there is pihole-FTL build for mipsle pihole-FTL.zip

janisz commented 4 years ago

Released version is here https://github.com/janisz/FTL/releases/tag/v4.3.1

abesnier commented 2 years ago

Sorry to comment on an old closed issue, but I recently tried to build FTL on a mips machine (GnuBee). Build failed with errors:

/home/git/FTL/src/database/../shmem.h:57:41: error: expected declaration specifiers or ‘...’ before numeric constant
   57 | ASSERT_SIZEOF(countersStruct, 240, 240, 240);

(multiple messages like this).

Just modifiyng src/static_asserts.h line 21 by replacing #elif defined(__i386__) with #elif defined(__i386__) || defined(__mips__) is enough.

I will not make a PR, as mips is not a supported architecture, but this comment may help future users.

DL6ER commented 2 years ago

I won't hurt to have FTL compile for MIPS even when we cannot afford resources to officially support it. Go ahead and open a PR if you want to.