search

pi-hole / PADD

PADD (formerly Chronometer2) is a more expansive version of the original chronometer.sh that is included with Pi-Hole. PADD provides in-depth information about your Pi-hole.
1.36k stars 122 forks source link

printf-error: not completely converted #334

Closed marwenius closed 1 year ago

marwenius commented 1 year ago

Describe the bug With each refresh these error messages are displayed:

./padd.sh: 184: printf: 37,552: not completely converted
./padd.sh: 914: printf: 13,0: not completely converted
./padd.sh: 941: printf: 4,5: not completely converted
./padd.sh: 941: printf: 1,3: not completely converted

To Reproduce Steps to reproduce the behavior:

  1. start ./padd.sh (no matter whether via .bashrc or manually)

Expected behavior No error messages.

Screenshots none

Additional context

rdwebdesign commented 1 year ago

Looks like your system is returning the values using comma as decimal separator and PAAD is not expecting these values.

What is the output of locale on the command line?

yubiuser commented 1 year ago

Please change the lines at the beginning from

LC_ALL=C
LC_NUMERIC=C

to

export LC_ALL=C
export LC_NUMERIC=C

and see if this fixes your issue.

marwenius commented 1 year ago

Looks like your system is returning the values using comma as decimal separator and PAAD is not expecting these values.

What is the output of locale on the command line?

LANG=de_DE.UTF-8 LANGUAGE= LC_CTYPE="de_DE.UTF-8" LC_NUMERIC="de_DE.UTF-8" LC_TIME="de_DE.UTF-8" LC_COLLATE="de_DE.UTF-8" LC_MONETARY="de_DE.UTF-8" LC_MESSAGES="de_DE.UTF-8" LC_PAPER="de_DE.UTF-8" LC_NAME="de_DE.UTF-8" LC_ADDRESS="de_DE.UTF-8" LC_TELEPHONE="de_DE.UTF-8" LC_MEASUREMENT="de_DE.UTF-8" LC_IDENTIFICATION="de_DE.UTF-8" LC_ALL=

Please change the lines at the beginning from

LC_ALL=C
LC_NUMERIC=C

to

export LC_ALL=C
export LC_NUMERIC=C

and see if this fixes your issue.

The issue is fixed. Thank you!

yubiuser commented 1 year ago

Fix released with https://github.com/pi-hole/PADD/releases/tag/v3.10.1