search

pi-hole / api

The Pi-hole API
Other
162 stars 22 forks source link

Remove explicitly setting foreign key pragma #207

Closed AzureMarker closed 5 years ago

AzureMarker commented 5 years ago

The SQLite library will be compiled with foreign key support automatically by libsqlite3-sys when using the bundled feature (see their build.rs).

Our custom SQLite connection, connection manager, and module were renamed to reflect that they no longer explicitly add foreign key support.

codecov[bot] commented 5 years ago

Codecov Report

Merging #207 into development will increase coverage by <.01%. The diff coverage is 71.42%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #207      +/-   ##
===============================================
+ Coverage        69.28%   69.29%   +<.01%     
===============================================
  Files               91       91              
  Lines             6258     6256       -2     
  Branches          1155     1154       -1     
===============================================
- Hits              4336     4335       -1     
  Misses             979      979              
+ Partials           943      942       -1
Impacted Files Coverage Δ
src/databases/ftl/testing.rs 100% <ø> (ø) :arrow_up:
src/databases/gravity/model.rs 0% <0%> (ø) :arrow_up:
src/databases/ftl/model.rs 65% <0%> (ø) :arrow_up:
src/databases/custom_connection.rs 62.5% <100%> (ø)
src/databases/common.rs 74.35% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6b3c569...4ec3807. Read the comment docs.