pi-hole / docker-pi-hole

Pi-hole in a docker container
https://pi-hole.net
Other
8.39k stars 1.12k forks source link

Tidy up a few things in the readme and code. #1551

Closed PromoFaux closed 6 months ago

PromoFaux commented 6 months ago

What does this PR aim to accomplish?:

Dipping my toes back into the water.


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

PromoFaux commented 6 months ago

Test need adjustment.

Ah yes, maybe I will move back to its own function for easier testing.

rdwebdesign commented 6 months ago

This link in the Pi-hole features section is broken.

It is pointing to an old section:

Also, we should use a link to the repo main page (example: https://github.com/pi-hole/pi-hole#getting-in-touch-with-us), instead of the file contents (https://github.com/pi-hole/pi-hole/blob/master/README.md#getting-in-touch-with-us).