Updated the instructions to free up port 53 in Fedora - Githubissues

pi-hole / docker-pi-hole

Pi-hole in a docker container

https://pi-hole.net

Other

8.6k stars 1.13k forks source link

Updated the instructions to free up port 53 in Fedora #1660

Open OptimoSupreme opened 6 days ago

OptimoSupreme commented 6 days ago

Description

Added a dedicated Fedora section below Ubuntu's since the Ubuntu instructions no longer work on Fedora.
Added 'Debian' to the title of the Ubuntu section since it is applicable there as well.
Fixed the heading level for Ubuntu to match the rest of the readme.

Motivation and Context

This provides Fedora Pihole user with accurate instructions on how to free port 53, which they do not currently have. Existing Issue.

How Has This Been Tested?

This does not affect any other project code. I have verified that the included commands work as expected on a Fedora 41 server.

Types of changes

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[X] My code follows the code style of this project.
[X] My change requires a change to the documentation.
[X] I have updated the documentation accordingly.

rdwebdesign commented 5 days ago

I think, both sections (Debian/Fedora) should go to https://docs.pi-hole.net/main/prerequisites/

I agree. This README is too long and contains too many details, but not all are directly related to docker.

Maybe the best approach would be to put these 3 items under "Tips and Tricks" with links to external pages:

but we first need to create the pages for the first 2 items in https://docs.pi-hole.net.