pi-hole / docker-pi-hole

Pi-hole in a docker container
https://pi-hole.net
Other
8.62k stars 1.14k forks source link

Flush logs does not work from admin panel #341

Closed hansmbakker closed 5 years ago

hansmbakker commented 6 years ago

This is a...

Description

I have pi-hole v4.0 in docker on a Raspberry Pi (Hypriot).

Pi-hole works but the flush logs button in the admin panel (settings page) does not work.

Expected Behavior

Logs are removed and stats on the dashboard are reset

Actual Behavior

Query logs are not removed and stats on the dashboard are still the same

Possible Fix

Context and extra information

Your Environment

diginc commented 6 years ago

Thanks for the report.

Mine did the same thing that you described. I then disabled Pi-hole and re-enabled it, at which point the dashboard updated with no stats.

Looks like the web interface just runs pihole -f behind the scenes and that behaves similarly from the command line: the dashboard still shows the previous stats until you force restart. I don't think the restart should be necessary since I don't see a restart in the piholeLogFlush.sh source code at all. I'll do some more checking.

diginc commented 6 years ago

@Mcat12 reported this is fixed on the development branch of https://github.com/pi-hole/pi-hole which I do not have an image of currently so there should be a fix down the road.

It's in my backlog to create a bleeding edge development container too (with the pi-hole dev, not just docker dev work).

diginc commented 5 years ago

This maybe fixed in the newest version.

mr-bolle commented 5 years ago

@diginc i flush the logs over the Admin Panel with follow Pi-Hole Versions successfull

Pi-hole Version v4.2 & v4.2.1 Web Interface Version v4.2 FTL Version v4.2

04-02-_2019_08-57-50

diginc commented 5 years ago

Thanks for confirming @mr-bolle