search

pi-hole / docs

The official Pi-hole documentation
https://docs.pi-hole.net/
Creative Commons Attribution Share Alike 4.0 International
201 stars 208 forks source link

Enable IPv6 in Unbound config by default #1010

Open ThomasKramps opened 6 months ago

ThomasKramps commented 6 months ago

Thank you for your contribution to the Pi-hole Community!

Please read the comments below to help us consider your Pull Request.

We are all volunteers and completing the process outlined will help us review your commits quicker.

Please make sure you

  1. Base your code and PRs against the repositories developmental branch.
  2. Sign Off all commits as we enforce the DCO for all contributions
  3. Sign all your commits as they must have verified signatures
  4. File a pull request for any change that requires changes to our documentation at our documentation repo

What does this PR aim to accomplish?:

Wouldn't it be a good idea to enable IPv6 by now?

How does this PR accomplish the above?:

This PR changes the unbound config to enable IPv6 by default.

By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.
netlify[bot] commented 6 months ago

Deploy Preview for pihole-docs ready!

Name Link
Latest commit eaac0f05b3a2fe3ad2ccbea0fe7eb1f7eac7a124
Latest deploy log https://app.netlify.com/sites/pihole-docs/deploys/66009f1f250ce600086cc6f4
Deploy Preview https://deploy-preview-1010--pihole-docs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

DL6ER commented 6 months ago

What happens if the system doesn't have IPv6? They still happens a lot today, especially worth mentioning inside most docker containers.

rdwebdesign commented 6 months ago

As far as I know, docker IPv6 is disabled by default and even when enabled, some features are still considered experimental:

Also, it only works in Linux (it doesn't work on Docker Desktop for Windows/Mac)

Personally, I don't think this option should be set as default.

ThomasKramps commented 6 months ago

Hm, I wasn't aware of the docker situation. I'm using the normal Linux installation.

I just tested the suggested config in a docker container (without IPv6-Support) and had no issues. Everything still works fine.