pi-hole / docs

The official Pi-hole documentation
https://docs.pi-hole.net/
Creative Commons Attribution Share Alike 4.0 International
192 stars 202 forks source link

Document hidden PIHOLE_SELINUX variable #316

Open jb044 opened 4 years ago

jb044 commented 4 years ago

In raising this issue, I confirm the following: {please fill the checkboxes, e.g: [X]}

How familiar are you with the the source code relevant to this issue?:

{Replace this with a number from 1 to 10. 1 being not familiar, and 10 being very familiar}

7


Expected behaviour:

{A detailed description of what you expect to see}

pihole update code for 5 release checks for SELinux and exits if it is enabled, however there is also a shell variable PIHOLE_SELINUX. If this is set pihole -up continues with SELinux either enabled or enabled and in enforcing mode. I understand there are issues with pihole as is with SELinux and have taken measures to let it function with SELinux enforcing to a degree I can live with.

IMHO this variable should be either mentioned by the installer in update mode or documented. I just stumbled upon it in your source code.

Actual behaviour:

pihole -up on 4->5 updates pihole and the webinterface but not FTL, and thus breaks itself.

{A detailed description and/or screenshots of what you do see}

Steps to reproduce:

pihole -up on any system with SELinux enabled.

{Detailed steps of how we can reproduce this}

export PIHOLE_SELINUX=true

pihole -up

Succes

pihole -up

Failure

Debug token provided by uploading pihole -d log:

{Alphanumeric token}

Troubleshooting undertaken, and/or other relevant information:

{Steps of what you have done to fix this}

  • You must follow the template instructions. Failure to do so will result in your issue being closed.
  • Please submit any feature requests here, so it is votable and trackable by the community.
  • Please respect that Pi-hole is developed by volunteers, who can only reply in their spare time.
  • Detail helps us understand and resolve an issue quicker, but please ensure it's relevant.
  • This template was created based on the work of udemy-dl.
bcambl commented 4 years ago

@jb044 First off.. congrats finding my hidden variable! šŸ„‡
Glad to hear you managed to build a policy that works for you.

I have renamed this issue and transfered it to the documentation repo.