Installer does not fail with blank IP address blocks.

[dschaper]

In raising this issue, I confirm the following (please check boxes, eg [X]) Failure to fill the template will close your issue:

• [X] I have read and understood the contributors guide.
• [X] The issue I am reporting can be replicated
• [X] The issue I'm reporting isn't a duplicate (see FAQs, closed issues, and open issues).

How familiar are you with the codebase?:

10

---

[BUG]:

[BUG] Expected Behaviour: If the installer or reinstaller detects that setupVars is not in the correct format, it should error out.

See https://discourse.pi-hole.net/t/new-install-and-not-blocking-ads/2781

[BUG] Actual Behaviour: If IPV4 address or IPv6 address is listed, but blank, installer thinks that blank is a valid IP address.

This template was created based on the work of udemy-dl.

[PromoFaux]

The IPv6 field is always there, even if IPv6 is not configured (Do we want to change this?)

That said, I've just tried blanking out both IP addresses is my setupVars.conf and I get the following message when running the installer:

It seems to be working as intended.. however, do we wish to actually remove the field if it has a blank value?

[jacobsalmela]

Yes, @PromoFaux I think you fixed this here. If @dschaper or anyone else can confirm this is no longer an issue, we can close this issue.

[jacobsalmela]

This is indeed fixed. The installer shows

  You may now configure your devices to use the Pi-hole as their DNS server
  [i] Pi-hole DNS (IPv4): xxx.xxx.xxx.xxx
  [i] Pi-hole DNS (IPv6): ::1
  If you set a new IP address, please restart the server running the Pi-hole

  [i] The install log is located at: /etc/pihole/install.log
  Installation Complete! 

and

root@pihole:~# pihole -g
  No IP addresses found! Please run 'pihole -r' to reconfigure