search

pi-hole / pi-hole

A black hole for Internet advertisements
https://pi-hole.net
Other
48.41k stars 2.67k forks source link

Give the uninstaller some attention - broken on v6 #5452

Open yubiuser opened 10 months ago

yubiuser commented 10 months ago

Reported here: https://discourse.pi-hole.net/t/uninstall-broken/65775

pralor-bot commented 10 months ago

This issue has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/uninstall-broken/65775/6

github-actions[bot] commented 9 months ago

This issue is stale because it has been open 30 days with no activity. Please comment or update this issue or it will be closed in 5 days.

rdwebdesign commented 3 months ago

I think we also need to change some things in the installer and pihole.

Reading the code, I can see the current installer (just like the uninstaller) always considers webroot as /var/www/html, the path as /admin and the port as 8080, but these values could be changed by the user with webserver.paths.webroot, webserver.paths.webhome and webserver.port.

If the user changes these values, commands like pihole -r and pihole checkout web will fail.