pi-hole / pi-hole

A black hole for Internet advertisements
https://pi-hole.net
Other
48.97k stars 2.69k forks source link

Duplicate output when updating FTL #5772

Open compulsions opened 1 month ago

compulsions commented 1 month ago

Versions

Core Version is v5.18.3-490-g0cf0b2ab (Latest: null) Branch is development Hash is 0cf0b2ab (Latest: 0cf0b2ab) Web Version is v5.21-947-g05c286df (Latest: null) Branch is development Hash is 05c286df (Latest: 05c286df) FTL Version is vDev-72bfc98 (Latest: null) Branch is development Hash is 72bfc983 (Latest: 72bfc983)

Platform

Expected behavior

Not have repeatable output when doing pihole -up

Actual behavior / bug

[i] Checking for updates... [i] Pi-hole Core: up to date [i] Web Interface: up to date [i] FTL binary already installed, verifying integrity... [✗] Remote binary is different, downloading... [i] FTL: update available

[✓] Detected AArch64 (64 Bit ARM) architecture [i] FTL binary already installed, verifying integrity... [✗] Remote binary is different, downloading... [✓] Downloading and Installing FTL [✓] Installing scripts from /etc/.pihole

Steps to reproduce

Perform a pihole -up when there is an update available.

Debug Token

Screenshots

image

Additional context

Is it possible to remove the following output [i] FTL binary already installed, verifying integrity... [✗] Remote binary is different, downloading... at the top when checking if the components are up to date and keep the other one?

github-actions[bot] commented 1 week ago

This issue is stale because it has been open 30 days with no activity. Please comment or update this issue or it will be closed in 5 days.

compulsions commented 1 week ago

Could you please share if this is something that is going to be considered, if not I can close the issue

yubiuser commented 1 week ago

Should be fixed by https://github.com/pi-hole/pi-hole/pull/5800