Ctrl + Click on query page isn't OS friendly

pi-hole / web

Pi-hole Dashboard for stats and more

https://pi-hole.net

Other

2.03k stars 559 forks source link

Ctrl + Click on query page isn't OS friendly #1570

Closed DalenW closed 2 years ago

DalenW commented 4 years ago

https://github.com/pi-hole/AdminLTE/blob/a03d1bddf74f0164f637126b06705bb659dfa4e7/scripts/pi-hole/js/queries.js#L510

Currently this displays "Ctrl + Click" on all systems. On macOS this behavior is really "Cmd + Click". A simple if statement using navigator.platform can check if the website is on macOS or Windows or Linux, and return the correct key combo.

yubiuser commented 4 years ago

Your're right, the tooltip only says "Ctrl+Click" but below the table it's already macOS friendly :)

Bildschirmfoto zu 2020-08-31 08-06-24

Pinging @PromoFaux as he drafted a modified version that makes the filtering a bit more user friendly. He might change the tooltip as well.

PromoFaux commented 4 years ago

I didn't even notice the tooltip (shows how often I actually use the ui!) Will take a look

DL6ER commented 4 years ago

navigator.platform isn't necessarily reliable. Firefox adopted anti-fingerprinting from the Tor Browser, causing the screen resolution to be randomized for the website. Similarly, the local time zone can be shuffled. It wouldn't wonder if this does also involve randomizing the navigator object to avoid identification of the user by browser version, operating system or maybe even platform.

Just a word of caution here. I intentionally put both into the table @yubiuser showed above.

github-actions[bot] commented 2 years ago

This issue is stale because it has been open 30 days with no activity. Please comment or update this issue or it will be closed in 5 days.

PromoFaux commented 2 years ago

This is no longer an issue in newer versions of Pi-hole: