Closed DalenW closed 2 years ago
Your're right, the tooltip only says "Ctrl+Click" but below the table it's already macOS friendly :)
Pinging @PromoFaux as he drafted a modified version that makes the filtering a bit more user friendly. He might change the tooltip as well.
I didn't even notice the tooltip (shows how often I actually use the ui!) Will take a look
navigator.platform
isn't necessarily reliable. Firefox adopted anti-fingerprinting from the Tor Browser, causing the screen resolution to be randomized for the website. Similarly, the local time zone can be shuffled. It wouldn't wonder if this does also involve randomizing the navigator
object to avoid identification of the user by browser version, operating system or maybe even platform.
Just a word of caution here. I intentionally put both into the table @yubiuser showed above.
This issue is stale because it has been open 30 days with no activity. Please comment or update this issue or it will be closed in 5 days.
This is no longer an issue in newer versions of Pi-hole:
https://github.com/pi-hole/AdminLTE/blob/a03d1bddf74f0164f637126b06705bb659dfa4e7/scripts/pi-hole/js/queries.js#L510
Currently this displays "Ctrl + Click" on all systems. On macOS this behavior is really "Cmd + Click". A simple if statement using navigator.platform can check if the website is on macOS or Windows or Linux, and return the correct key combo.