search

pi-hole / web

Pi-hole Dashboard for stats and more
https://pi-hole.net
Other
2.04k stars 558 forks source link

Update user interface terminology to use inclusive language #2137

Open rjbrown99 opened 2 years ago

rjbrown99 commented 2 years ago

Hi, I noticed that the web user interface continues to use the terms 'blacklist' and 'whitelist'. Could we please consider rebranding to blocklist/allowlist or something similar?

Examples of other tech companies/projects making this change - https://help.sap.com/doc/b0322267728e48a28b0c8ee7dd1ab4c7/1.0/en-US/Inclusive%20Language%20Guidelines.pdf https://www.cnet.com/tech/computing/apple-banishes-blacklist-and-master-branch-in-push-for-inclusive-language/ https://thenewstack.io/words-matter-finally-tech-looks-at-removing-exclusionary-language/

Thanks for the consideration.

PromoFaux commented 2 years ago

We're already in the process of adjusting the naming of various parts of the application. We're in the middle of a major update with breaking changes to version 6, and part of that already includes language changes to this effect. The changes are not easy to make to the existing code. We've had a few PRs that have tried and have not had success with the current code base. https://github.com/pi-hole/AdminLTE/issues/1448#issuecomment-908800517

Since we're all volunteers on this project, it takes some time to get changes like this ready. The change will include an API that is internal to the pihole-FTL daemon and an internal c-based http daemon (see https://github.com/pi-hole/AdminLTE/tree/new/FTL_is_my_new_home and 0ccade48 and 571a9463). We need to alpha and beta this code heavily with our users as this will break existing convenience and third party scripts that rely on our old telnet API interface. We're taking 5+ years of kittens and training them to be cattle. Add to that Covid, expanding families, and just general life the last two years slowed our progress, but we are still progressing.

rjbrown99 commented 2 years ago

First of all thank you for the thoughtful reply @PromoFaux. Glad this is in flight - and as you go I'm happy to sign up as one of your alpha/beta testers. I do have at least some external scripting tied to PiHole (specifically Home Assistant) so it might be a worthwhile check of an external interface.

bmikol commented 2 years ago

+1 on this (in terms of the request, appreciation that it's already inflight, and volunteering to help). In terms of ideas for naming convention, Pendo has renamed to Include and Exclude Lists which I think also clearly communicate the functionality.

1reverseengineer commented 1 year ago

Since I can't open a feature request on discourse.pihole (no explanation, nothing in the FAQ, great job whoever is responsible for that UI/UX).

Why did PiHole remove the Blacklist and Whitelist tab? Instead now they are both in the domains tab. Why, it's confusing, it requires substantially more clicks, it's pointless.

Again, why? There has to be an explanation, because I quite frankly can't possibly come up with an explanation, as to why someone would worsen an already perfect interface section so utterly beyond believe. Again, there was no necessity to group black- and whitelists together. Ever.

yubiuser commented 1 year ago

Thanks for hijacking this issue report and your constructive feedback.

Feature requests on discourse require users to have spent a minimum amount of time at the forum to prevent drive-by-requests.

As always, UI decisions won't never suit everyone's taste. https://github.com/pi-hole/AdminLTE/pull/2266