Unable to add regex to blacklist all domains - Githubissues

pi-hole / web

Pi-hole Dashboard for stats and more

https://pi-hole.net

Other

2.05k stars 558 forks source link

Unable to add regex to blacklist all domains #2335

Closed jasonlboggs closed 2 years ago

jasonlboggs commented 2 years ago

Versions

Pi-hole version is v5.12 (Latest: v5.12)
AdminLTE version is v5.14.2 (Latest: v5.14.2)
FTL version is v5.17 (Latest: v5.17)

Platform

OS and version: Debian 11
Platform: HP Thinclient T570 (I think?)

Expected behavior

I am doing a fresh install of PiHole on a new machine due to my existing machine on Ubuntu 18.04 Server that will not upgrade to the latest FTL (stuck on v5.16.1).

I did a fresh install of Debian 11 (supports 32 bit machines). On my previous machine, I was able to add .*? as a whiltelist and a blacklist, and then apply these to "Unrestricted" and "BlockEverything" groups so I can allow all network devices to either have full access or block all DNS lookups. This works as intended on the existing machine. On the new machine, when I add these same regex entries using the UI, it simply adds a blank space ( ).

Existing machine on v5.16.1:

New machine on v5.17:

Actual behavior / bug

I am unable to add an all-domain regex filter to blacklist/whitelist all domains

Steps to reproduce

Steps to reproduce the behavior:

Navigate to the Domains page and open the RegEx Filter tab
Attempt to add the following regex filter .*? as either blacklist or whitelist

Debug Token

URL: https://tricorder.pi-hole.net/huCptCyi/

Screenshots

If applicable, add screenshots to help explain your problem.

Additional context

Add any other context about the problem here.

yubiuser commented 2 years ago

As a workaround, add it via the terminal

pihole -b --regex ".*?"

yubiuser commented 2 years ago

Please try if the special branch fixes the issue for you:

pihole checkout web fix/IDNA

To go back on track use pihole checkout web master

jasonlboggs commented 2 years ago

This fixes the issue! Thank you!

pralor-bot commented 2 years ago

This issue has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/problem-with-regular-expression-not-saving/57690/4

pralor-bot commented 2 years ago

This issue has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/kann-keine-regex-einfugen/57704/4

yubiuser commented 2 years ago

Fix released with https://discourse.pi-hole.net/t/pi-hole-ftl-v5-18-web-v5-15-and-core-v5-12-1-released/57894