pi-hole / web

Pi-hole Dashboard for stats and more
https://pi-hole.net
Other
2.02k stars 560 forks source link

Web Interface locks up after being up open for a long time. #2424

Open amirHizkiya opened 1 year ago

amirHizkiya commented 1 year ago

Versions

Platform

Expected behavior

After having the Web UI open for a while (A few days?) I click on disable blocking -> 5 min. I'm hoping that the Blocking gets disabled.

Actual behavior / bug

What actually happens (After the UI is open a while). Clicking on Disable Blocking ->For 5 Minutes. The spinner shows, but it doesn't spin. I need to actually refresh the page to actually be able to disable blocking

Steps to reproduce

Steps to reproduce the behavior:

  1. Open Web Interface and leave open for a few hours (1 day?)
  2. Click on Disable Blocking -> For 5 Minutes
  3. See error: Spinner shows but doesn't spin. Doesn't actually disable blocking.

Additional context

Super low priority, bit this has been present for quite a few versions. Ill confirm that it shows up in the newest version.

rdwebdesign commented 1 year ago

Thanks for the report. I can confirm the behavior.

This happens because the session has expired (after the UI is open for a long time), but there is no response when you click the button.

Note: As you said, it's low priority. This is not a security issue, as the button only works if the session is active, but I think it can be a bit annoying for those who often leave the page open in their browser.

amirHizkiya commented 1 year ago

Great! I just wanted to make sure that it was logged.

It is a little annoying, but I'm sure there are bigger issues to tackle.

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 30 days with no activity. Please comment or update this issue or it will be closed in 5 days.

amirHizkiya commented 1 year ago

This is still a thing, and I didn't want it to be auto-closed.

amirHizkiya commented 9 months ago

Any chance to sneak this into v6?

rdwebdesign commented 9 months ago

v6 doesn't use PHP to handle sessions.

In v6, this won't happen because the web interface will show the login page when session is expired.

amirHizkiya commented 9 months ago

Amazing! Thx.