search

pi-hole / web

Pi-hole Dashboard for stats and more
https://pi-hole.net
Other
2.04k stars 559 forks source link

Tools > Search adlists has not obvious default behaviour when pressing Enter inside textbox #2701

Closed tobbi closed 7 months ago

tobbi commented 1 year ago

Versions

Platform

Expected behavior

The button for the action that gets executed when pressing Enter in the Search Adlists text field is highlighted.

Actual behavior / bug

When pressing Enter inside the "Domain to look for (example.com or sub.example.com)", it is not clear whether "Search partial match" or "Search exact match" is triggered. From the behaviour, it looks like it's "Search partial match", but this is not clear to the user.

Steps to reproduce

Steps to reproduce the behavior:

  1. Go to Tools > Search adlists.
  2. Click inside the "Domain to look for (example.com or sub.example.com)" textbox and enter a search term.
  3. Press Enter
github-actions[bot] commented 1 year ago

This issue is stale because it has been open 30 days with no activity. Please comment or update this issue or it will be closed in 5 days.

tobbi commented 1 year ago

Yo momma is stale!

yubiuser commented 1 year ago

You're correct this is a UI bug.

github-actions[bot] commented 11 months ago

This issue is stale because it has been open 30 days with no activity. Please comment or update this issue or it will be closed in 5 days.

github-actions[bot] commented 10 months ago

This issue is stale because it has been open 30 days with no activity. Please comment or update this issue or it will be closed in 5 days.

github-actions[bot] commented 9 months ago

This issue is stale because it has been open 30 days with no activity. Please comment or update this issue or it will be closed in 5 days.

github-actions[bot] commented 8 months ago

This issue is stale because it has been open 30 days with no activity. Please comment or update this issue or it will be closed in 5 days.

tobbi commented 8 months ago

Can this please be reopened?

tobbi commented 8 months ago

Is there a way to prevent the bot from marking this as "stale"?

DL6ER commented 8 months ago

We could either put the never-stale label on it or fix the underlying issue itself :-)

I propose the latter: https://github.com/pi-hole/web/pull/2957

github-actions[bot] commented 7 months ago

This issue is stale because it has been open 30 days with no activity. Please comment or update this issue or it will be closed in 5 days.