Multi delete only deletes first item

pi-hole / web

Pi-hole Dashboard for stats and more

https://pi-hole.net

Other

2.02k stars 560 forks source link

Multi delete only deletes first item #2760

Closed yubiuser closed 11 months ago

yubiuser commented 11 months ago

Tested on Adlists, but probably also in other places, multi-selecting and deleting only deletes the first item. It also does not reload the table afterwards

DL6ER commented 11 months ago

Wasn't this already fixed by https://github.com/pi-hole/web/pull/2751 ?

yubiuser commented 11 months ago

Mhh.. let me check

yubiuser commented 11 months ago

Ah true. Switching all those branches all the time got me confused

nanopi@nanopi:~$ pihole -v
  Pi-hole version is gravity_success_msg v5.17.1-169-g27522fb (Latest: v5.17.2)
  web version is gravity_success_msg v5.19-339-g7c5908fc (Latest: v5.20.2)
  FTL version is tweak/domain_array vDev-bc72fe6 (Latest: v5.23)

It happend when reviewing https://github.com/pi-hole/web/pull/2707 which let me add numerous adlists but is not yet based on latest devleopment and I had to delete them one by one.