pi-hole / web

Pi-hole Dashboard for stats and more
https://pi-hole.net
Other
2.02k stars 559 forks source link

Dark theme is not applied on .user-body at dropdown-menu on navbar #2763

Closed anwiese closed 11 months ago

anwiese commented 11 months ago

Versions

Platform

Expected behavior

Dark theme should apply on all elements of the dropdown menu in the top right corner of the web interface.

Actual behavior / bug

The dark theme is not applied on the CSS element .user-body. The value background-color: #272c30; is missing. It only exists at the element user-footer.

Steps to reproduce

Steps to reproduce the behavior:

  1. Click on the dropdown menu in the top right corner
  2. See error

Debug Token

Screenshots

image

Additional context

Add any other context about the problem here.

rdwebdesign commented 11 months ago

The dark theme is not applied

Which theme are you using? image

I can't reproduce the issue using our dark themes (Midnight, Deep Midnight, High Contrast Dark and LCARS).

dark_themes

Also, which browser? Do you see the same on different browsers/devices?

anwiese commented 11 months ago

I used Chrome 118.0.5993.71 on Windows 11 22H2 with the theme "Pi-hole auto". In Windows the Dark theme is used. When i switch to "Pi-hole midnight", everthing works as expected. On an iPad mini 6 with iPad OS 17.0.3 and the dark theme enabled, I can reproduce the error with Safari and the dark theme of the device when using the "Pi-hole auto" theme.

When I check the Dev Tools in the Chrome Browser it looks like the browser is loading both default-dark.css and default-light.css while using "Pi-hole auto" and a dark theme of the operating system. The declaration seems to come from the loaded default-light.css. When I use the day theme or midnight theme, only the corresponding css file is loaded in the browser.

Screenshot 2023-10-18 204743

rdwebdesign commented 11 months ago

Thanks.

I tested on Firefox using dark mode. The theme Pi-hole auto is showing the same issue.

It's a simple fix.

rdwebdesign commented 11 months ago

Fixed in development-v6.