search

pi-hole / web

Pi-hole Dashboard for stats and more
https://pi-hole.net
Other
1.98k stars 549 forks source link

Disabled Blocking doesn't get resumed after timer expiry. #3026

Closed ghpk closed 2 months ago

ghpk commented 2 months ago

Versions

-Pi-hole version is v5.18.2 (Latest: v5.18.2) -web version is v5.21 (Latest: v5.21) -FTL version is v5.25.2 (Latest: v5.25.2)

Platform

Expected behavior

A clear and concise description of what you expected to happen. After disabling blocking for say 60 minutes, although the web interface shows its active, ads keep coming on all connected devices until I go again and disable blocking and then enable it manually from web interface.

Actual behavior / bug

Blocking should resume back after timer expiry as its always been in past years.

A clear and concise description of what the bug is.

Steps to reproduce

Steps to reproduce the behavior:

  1. Go to 'web admin page'
  2. Click on 'disable blocking'
  3. Scroll down to 'for custom time.'
  4. after time expires, blocking doesn't gets resumed

Debug Token

Screenshots

If applicable, add screenshots to help explain your problem.

Additional context

Add any other context about the problem here.

rdwebdesign commented 2 months ago

I tested in my browser and I didn't see the same issue.

I also tested using the command line. I executed the command watch -d dig flurry.com @<pihole_IP> in a terminal window and disabled Pi-hole for 15 seconds using the web interface.

watch_dig

The output showed flurry.com was allowed during the 15 seconds. After the time expired the answer was 0.0.0.0, meaning the domains was immediately blocked.

Can you please generate a debug log as requested on the template?

ghpk commented 2 months ago

Thanks for looking into this, Can you please also try setting a custom time disable blocking. It may be possible only custom time may have an issue.

I tried generating debug log, But after long wait and confirmation to upload it fails to generate. On my original post, I included that error message. Will post again in a few hours.

ghpk commented 2 months ago

Accidentally closed

rdwebdesign commented 2 months ago

Can you please also try setting a custom time disable blocking.

My test above was made using the Custom Time option. I set the timer for 15 seconds.