search

pi-hole / web

Pi-hole Dashboard for stats and more
https://pi-hole.net
Other
1.98k stars 549 forks source link

Base expert icon on expert class not FTL advanced flag #3043

Closed yubiuser closed 1 month ago

yubiuser commented 1 month ago

What does this PR aim to accomplish?:

Show the wrench icon for expert level settings based on the expert class of the the parents (set manually) not based on the FTL 'advanced-setting' flag.

This PR is the counterpart for https://github.com/pi-hole/FTL/pull/1883 which will remove the advanced flag, but keeps the wrench icon at the setting boxes when they are considered expert-level.

For background see https://github.com/pi-hole/web/pull/2882#issuecomment-1881872571

By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.
PromoFaux commented 1 month ago

Tested and working as expected. e.g Running this branch alongside the companion FTL PR, the wrench icon is restored on the "Query Anonymization" box where it is not present with the tweak/remove_expert_flag FTL branch alone.

@yubiuser DCObot is not happy it seems.... Once that's sorted I'll drop an approve!

yubiuser commented 1 month ago

I don't know why it's not happy. The commit is signed-off...