search

pi-hole / web

Pi-hole Dashboard for stats and more
https://pi-hole.net
Other
2.02k stars 560 forks source link

Use number_format for CPU load #3059

Closed strangelookingnerd closed 3 months ago

strangelookingnerd commented 3 months ago

Thank you for your contribution to the Pi-hole Community!

Please read the comments below to help us consider your Pull Request.

We are all volunteers and completing the process outlined will help us review your commits quicker.

Please make sure you

  1. Base your code and PRs against the repositories developmental branch.
  2. Sign Off all commits as we enforce the DCO for all contributions
  3. Sign all your commits as they must have verified signatures
  4. File a pull request for any change that requires changes to our documentation at our documentation repo

What does this PR aim to accomplish?:

CPU load in the header is currently rounded which can result in the value being 0 or 1 rather than 0.00 and 1.00. Adding the additional zeros in my opinion gives a better visual appearance.

How does this PR accomplish the above?:

Replace round with number_format and also making sure to use a dot as decimal separator. Since number_format is taking the current locale into account this could otherwise lead to the separator being a comma.

Link documentation PRs if any are needed to support this PR:

By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.
strangelookingnerd commented 3 months ago

Failure in Lint / PHP-CS-Fixer action seems to be unrelated to my changes.

yubiuser commented 3 months ago

Please note that all changes should be based on and target development-v6 as we do not plan to add new features to v5

strangelookingnerd commented 3 months ago

Please note that all changes should be based on and target development-v6 as we do not plan to add new features to v5

Oh, I see. Will re-create the PR for a clean history. This bit of info should be added to the contributing section as is still states devel.