search

pi-hole / web

Pi-hole Dashboard for stats and more
https://pi-hole.net
Other
1.98k stars 549 forks source link

Don't try to fill client/domain tables if there is no data #3069

Closed yubiuser closed 2 weeks ago

yubiuser commented 2 weeks ago

What does this PR aim to accomplish?:

Fixes https://github.com/pi-hole/web/issues/3068.

Do not try to populate top domain/client tables at the dashboard if there is no data to fill in.

By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.
yubiuser commented 2 weeks ago

Force pushed the changes.