search

pi-hole / web

Pi-hole Dashboard for stats and more
https://pi-hole.net
Other
1.98k stars 549 forks source link

makes the graphs for TopClients & TopDomains behave like ClientsOverTime depending on Privacy Level #3070

Closed mwoolweaver closed 2 weeks ago

mwoolweaver commented 2 weeks ago

Thank you for your contribution to the Pi-hole Community!

Please read the comments below to help us consider your Pull Request.

We are all volunteers and completing the process outlined will help us review your commits quicker.

Please make sure you

  1. Base your code and PRs against the repositories developmental branch.
  2. Sign Off all commits as we enforce the DCO for all contributions
  3. Sign all your commits as they must have verified signatures
  4. File a pull request for any change that requires changes to our documentation at our documentation repo

What does this PR aim to accomplish?:

this makes the graphs for TopClients & TopDomains behave like ClientsOverTime depending on Privacy Level for consistency in behavior.

How does this PR accomplish the above?:

make the function here https://github.com/pi-hole/web/blob/60ca1c7cb2b64c5dc7d3eafc21addabf3fce9f1e/scripts/pi-hole/js/index.js#L296

and here https://github.com/pi-hole/web/blob/60ca1c7cb2b64c5dc7d3eafc21addabf3fce9f1e/scripts/pi-hole/js/index.js#L355

behave like the function found here https://github.com/pi-hole/web/blob/60ca1c7cb2b64c5dc7d3eafc21addabf3fce9f1e/scripts/pi-hole/js/index.js#L28

Link documentation PRs if any are needed to support this PR:

By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.